The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Equals method for de.jaret.util.date.JaretDate assumes the argument is of type JaretDate | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 586 | Medium |
| de.jaret.util.date.JaretDate.getDate() may expose internal representation by returning JaretDate._date | MALICIOUS_CODE | EI_EXPOSE_REP | 384 | Medium |
| de.jaret.util.date.JaretDate.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 586 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Equals method for de.jaret.util.date.JaretDateFormatter assumes the argument is of type JaretDateFormatter | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 88 | Medium |
| de.jaret.util.date.JaretDateFormatter.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 88-90 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to method of static java.util.Calendar in de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase.daysInMonth(int, int) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE | 428 | Medium |
| Call to method of static java.util.Calendar in de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase.getDate(int, int, int, int) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE | 171 | Medium |
| Call to method of static java.util.Calendar in de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase.getDate(int, int, int, int) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE | 163 | Medium |
| Call to method of static java.util.Calendar in de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase.getWeekday(Date) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE | 176 | Medium |
| de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase.getNamedDays(int, int, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 274 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$EasyDate(HolidayEnumeratorBase, Date) may expose internal representation by storing an externally mutable object into HolidayEnumeratorBase$EasyDate.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 457 | Medium |
| Call to method of static java.util.Calendar in new de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$EasyDate(HolidayEnumeratorBase, Date) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE | 456 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$NamedDateImpl.getDate() may expose internal representation by returning HolidayEnumeratorBase$NamedDateImpl._date | MALICIOUS_CODE | EI_EXPOSE_REP | 500 | Medium |
| new de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$NamedDateImpl(HolidayEnumeratorBase, Date, String, boolean) may expose internal representation by storing an externally mutable object into HolidayEnumeratorBase$NamedDateImpl._date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 484 | Medium |
| de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$NamedDateImpl.equals(Object) checks for operand being a java.util.Date | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 514 | High |
| Should de.jaret.util.date.holidayenumerator.HolidayEnumeratorBase$NamedDateImpl be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 475-535 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in de.jaret.util.date.holidayenumerator.HolidayEnumeratorFactory.instantiateHolidayEnumerator(Locale, String) | STYLE | REC_CATCH_EXCEPTION | 139 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.jaret.util.date.holidayenumerator.HolidayEnumerator_de_DE.getAvailableRegionIds() may expose internal representation by returning HolidayEnumerator_de_DE.REGIONIDS | MALICIOUS_CODE | EI_EXPOSE_REP | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.jaret.util.date.holidayenumerator.HolidayEnumerator_fr_FR.getAvailableRegionIds() may expose internal representation by returning HolidayEnumerator_fr_FR.REGIONIDS | MALICIOUS_CODE | EI_EXPOSE_REP | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Result of integer multiplication cast to long in de.jaret.util.date.iterator.HourIterator.getApproxStepMilliSeconds() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Result of integer multiplication cast to long in de.jaret.util.date.iterator.MinuteIterator.getApproxStepMilliSeconds() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Increment of volatile field de.jaret.util.date.timemachine.TimeMachine._currentTime in de.jaret.util.date.timemachine.TimeMachine.increment() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 72 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in de.jaret.util.misc.MiscUtil.readTextFile(String): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 75 | High |
| de.jaret.util.misc.MiscUtil.copyFile(File, File) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 93 | Medium |
| de.jaret.util.misc.MiscUtil.copyFile(File, File) may fail to clean up java.io.OutputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 94 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.jaret.util.swt.ColorManager._instances isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 28 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.jaret.util.swt.FontManager._instances isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 28 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in de.jaret.util.swt.SwtGraphicsHelper.reflect(Image, Device) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 466 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in de.jaret.util.ui.SmileyWidget.calcSmileFactor() | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in de.jaret.util.ui.console.ConsoleControl.getPrintStream(): new java.io.PrintStream(OutputStream) | I18N | DM_DEFAULT_ENCODING | 252 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should de.jaret.util.ui.console.ConsoleControl$ConsoleOutStream be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 276-288 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to te in de.jaret.util.ui.infoprovider.InfoProviderView.createControls() | STYLE | DLS_DEAD_LOCAL_STORE | 120 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should de.jaret.util.ui.infoprovider.InfoProviderView$IPTableLabelProvider be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 279-311 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should de.jaret.util.ui.infoprovider.InfoProviderView$IPTreeContentProvider be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 148-245 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should de.jaret.util.ui.infoprovider.InfoProviderView$IPTreeLabelProvider be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 248-252 | Medium |